mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 67387: Updated Mesos code to use `io::prepare_async`.
Date Fri, 08 Jun 2018 17:38:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67387/#review204499
-----------------------------------------------------------


Ship it!




Ship It!

- Andrew Schwartzmeyer


On May 30, 2018, 11:56 a.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67387/
> -----------------------------------------------------------
> 
> (Updated May 30, 2018, 11:56 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, John Kordich,
Joseph Wu, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-5371 and MESOS-8668
>     https://issues.apache.org/jira/browse/MESOS-5371
>     https://issues.apache.org/jira/browse/MESOS-8668
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Due to the previous patch, instances that use `os::nonblock` before
> sending the file descriptor to the async IO functions now need to use
> `io::prepare_async`.
> 
> 
> Diffs
> -----
> 
>   src/files/files.cpp 8d896ed59e88de86149e00ba80806b61aba15c86 
>   src/slave/container_loggers/logrotate.cpp bd41912fdf9faa70957a768ea5541e60824864ba

> 
> 
> Diff: https://reviews.apache.org/r/67387/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message