mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 67356: Made `TestContainerizerProcess::launch()` thread safe.
Date Fri, 15 Jun 2018 13:36:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67356/#review204832
-----------------------------------------------------------


Fix it, then Ship it!




I'll fix the outstanding issues and commit shortly.


src/tests/containerizer.cpp
Lines 128-129 (original), 128-129 (patched)
<https://reviews.apache.org/r/67356/#comment287575>

    ```
    // Assemble the environment for the executor.
        //
        // NOTE: Since in this case the executor will live in the same OS process,
        // pass the environment into the executor driver (library) c-tor directly
        // instead of manipulating `setenv`/`getenv` to avoid concurrent
        // modification of the environment.
    ```


- Alexander Rukletsov


On May 29, 2018, 2:21 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67356/
> -----------------------------------------------------------
> 
> (Updated May 29, 2018, 2:21 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, haosdent huang, Ilya
Pronin, and James Peach.
> 
> 
> Bugs: MESOS-3475
>     https://issues.apache.org/jira/browse/MESOS-3475
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch removes `os::setenv()`, `os::unsetenv()` calls that are
> currently used to implicitly configure both MesosExecutorDriver and
> v1 Executor via global environment variables. This change prepares a
> map containing modified environment and passes it to a constructor of
> an executor.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer.cpp c4e18b7c5d6937f53f806e94a40c969cdcac79eb 
> 
> 
> Diff: https://reviews.apache.org/r/67356/diff/5/
> 
> 
> Testing
> -------
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message