mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 67388: Moved libprocess POSIX and Windows implementations to separate folders.
Date Mon, 25 Jun 2018 22:55:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67388/#review205316
-----------------------------------------------------------


Ship it!





3rdparty/libprocess/src/io.cpp
Lines 136-147 (original), 41-50 (patched)
<https://reviews.apache.org/r/67388/#comment288245>

    Technically, you could remove these and then move the implementation in `src/posix/io.cpp`
out of the `internal` namespace.
    
    I'm fine with the diff as-is though.


- Joseph Wu


On June 21, 2018, 4:47 a.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67388/
> -----------------------------------------------------------
> 
> (Updated June 21, 2018, 4:47 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, John Kordich,
Joseph Wu, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8668
>     https://issues.apache.org/jira/browse/MESOS-8668
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In preparation of the new Windows IOCP library, the POSIX and Windows
> specific files in libprocess have been moved to their own directories
> for better code organization.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am 8910416ce4313a0d70721cf1bb1d1453aaf691f9 
>   3rdparty/libprocess/src/CMakeLists.txt 619183eff6d6d301a011ab03f007410f50a0aa4f 
>   3rdparty/libprocess/src/io.cpp 97f2b17092fbd23528cf3220fee5927a1ec38aba 
>   3rdparty/libprocess/src/io_internal.hpp PRE-CREATION 
>   3rdparty/libprocess/src/libev.hpp  
>   3rdparty/libprocess/src/libev.cpp  
>   3rdparty/libprocess/src/libev_poll.cpp  
>   3rdparty/libprocess/src/libevent.hpp  
>   3rdparty/libprocess/src/libevent.cpp  
>   3rdparty/libprocess/src/libevent_poll.cpp  
>   3rdparty/libprocess/src/libevent_ssl_socket.hpp  
>   3rdparty/libprocess/src/libevent_ssl_socket.cpp  
>   3rdparty/libprocess/src/poll_socket.cpp  
>   3rdparty/libprocess/src/posix/io.cpp PRE-CREATION 
>   3rdparty/libprocess/src/socket.cpp 504cb541785650d2d05aabd25f5258b9bad52baa 
>   3rdparty/libprocess/src/subprocess.cpp 0b2c02a9651563961532fdd5ab0f6d558f69f74e 
>   3rdparty/libprocess/src/subprocess_posix.hpp  
>   3rdparty/libprocess/src/subprocess_posix.cpp  
>   3rdparty/libprocess/src/subprocess_windows.hpp  
>   3rdparty/libprocess/src/subprocess_windows.cpp  
> 
> 
> Diff: https://reviews.apache.org/r/67388/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message