mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 67413: Refactored logic for `PYTHON` and `PYTHON_VERSION` in `configure.ac`.
Date Tue, 03 Jul 2018 14:32:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67413/
-----------------------------------------------------------

(Updated July 3, 2018, 2:32 p.m.)


Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, and Kevin Klues.


Changes
-------

Updated review request to not use `PYTHON_3` and `PYTHON_3_VERSION` yet.


Summary (updated)
-----------------

Refactored logic for `PYTHON` and `PYTHON_VERSION` in `configure.ac`.


Bugs: MESOS-8955
    https://issues.apache.org/jira/browse/MESOS-8955


Repository: mesos


Description (updated)
-------

This will facilitate the introduction of `PYTHON_3` and
`PYTHON_3_VERSION` to build the CLI in a future commit.


Diffs (updated)
-----

  configure.ac 8b8064aca7ae39e16dda40828b5a087b14b54a65 


Diff: https://reviews.apache.org/r/67413/diff/8/

Changes: https://reviews.apache.org/r/67413/diff/7-8/


Testing
-------

I added two lines after the new code:

```
AC_MSG_NOTICE([$PYTHON])
AC_MSG_NOTICE([$PYTHON_3])
```

My machine runs Python 2 when using `python` but `python3` is available. The result of `configure`
was:
```
configure: /usr/bin/python
configure: python3
```


Thanks,

Armand Grillet


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message