mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 67817: Improved logging for offers and inverse offers.
Date Wed, 04 Jul 2018 01:42:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67817/#review205706
-----------------------------------------------------------



Patch looks great!

Reviews applied: [67817]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On July 3, 2018, 8:56 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67817/
> -----------------------------------------------------------
> 
> (Updated July 3, 2018, 8:56 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Log offer IDs and inverse offer IDs when sending out offers and
> inverse offers so it is easier to match them to their ACCEPT or DECLINE
> calls and removals.
> 
> Also log at `VLOG(2)` level which resources are offered.
> 
> NOTE: It is possible to enable `VLOG(2)` logs just for `master.cpp` by
> setting the following env variable when starting the master:
> `GLOG_vmodule=master=2`.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2 
> 
> 
> Diff: https://reviews.apache.org/r/67817/diff/2/
> 
> 
> Testing
> -------
> 
> Manual testing =).
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message