mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 67821: Added override specifiers to XfsDiskIsolatorProcess methods.
Date Wed, 04 Jul 2018 04:11:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67821/#review205709
-----------------------------------------------------------



Patch looks great!

Reviews applied: [67820, 67821]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On July 3, 2018, 9:31 p.m., Ilya Pronin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67821/
> -----------------------------------------------------------
> 
> (Updated July 3, 2018, 9:31 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added override specifiers to XfsDiskIsolatorProcess methods.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/xfs/disk.hpp 9a5ca8bd60c61d65beed611a02dd26ed6a0a594b

> 
> 
> Diff: https://reviews.apache.org/r/67821/diff/1/
> 
> 
> Testing
> -------
> 
> Built Mesos with `--enable-xfs-disk-isolator` and ran `sudo make check`.
> 
> 
> Thanks,
> 
> Ilya Pronin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message