mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 67830: Moved `executor::Call` validation to common validation library.
Date Fri, 06 Jul 2018 00:29:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67830/#review205780
-----------------------------------------------------------



Patch looks great!

Reviews applied: [67830]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On July 5, 2018, 2:17 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67830/
> -----------------------------------------------------------
> 
> (Updated July 5, 2018, 2:17 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-9051
>     https://issues.apache.org/jira/browse/MESOS-9051
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `executor::Call` validation is used by both the agent and the
> executor driver, so move it to the common validation library.
> 
> 
> Diffs
> -----
> 
>   src/common/validation.hpp fa7f4a7164fda0f6af98c60a27e944146a231ee7 
>   src/common/validation.cpp f89b0ca886ef910d01cc0dba6e10505dc5e6ff6f 
>   src/executor/executor.cpp ab67caefd82f46eacd33221270b2c408ef70cd17 
>   src/slave/http.cpp aa9cdc5f58f73323958a6872e2721c83317f354c 
>   src/slave/validation.hpp 3a278e43f0e98c1ed6dcdec60e71c131973ccb43 
>   src/slave/validation.cpp 3e333a7b308ec9c42541036f52b48b4ad74f5b88 
> 
> 
> Diff: https://reviews.apache.org/r/67830/diff/1/
> 
> 
> Testing
> -------
> 
> make check (Fedora 28)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message