mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 67842: Refactored base of Python CLI tests.
Date Fri, 06 Jul 2018 14:28:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67842/#review205802
-----------------------------------------------------------




src/python/cli_new/lib/cli/tests/base.py
Lines 200-202 (patched)
<https://reviews.apache.org/r/67842/#comment288714>

    This should be in `Master.__del__()`, not `Master.kill()`



src/python/cli_new/lib/cli/tests/base.py
Lines 240-241 (original), 247-248 (patched)
<https://reviews.apache.org/r/67842/#comment288713>

    These need to be wrapped in e.g.:
    ```
    if hasattr(self, "flags") and hasattr(self.flags, "work_dir"):
    ```


- Kevin Klues


On July 6, 2018, 1:53 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67842/
> -----------------------------------------------------------
> 
> (Updated July 6, 2018, 1:53 p.m.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Bugs: MESOS-8955
>     https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Refactored base of Python CLI tests.
> 
> 
> Diffs
> -----
> 
>   src/python/cli_new/lib/cli/tests/base.py 4ffa27ca95ddf6575fb0a844d6996890bed4d8c9 
> 
> 
> Diff: https://reviews.apache.org/r/67842/diff/2/
> 
> 
> Testing
> -------
> 
> In `src/python/cli_new/`:
> ```
> $ source activate
> $ mesos-cli-tests
> ```
> Removed one of the binary and tried again to check that the error was correct.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message