mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 67791: Prevented master from asking agents to shutdown on auth failures.
Date Fri, 06 Jul 2018 19:27:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67791/#review205820
-----------------------------------------------------------



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67791']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67791

Relevant logs:

- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67791/logs/mesos-tests-stdout.log):

```
[ RUN      ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling
[       OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling (802 ms)
[ RUN      ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer
[       OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer (600 ms)
[ RUN      ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed
[       OK ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed (1225 ms)
[ RUN      ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure
[       OK ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure (798 ms)
[ RUN      ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure
[       OK ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure (802 ms)
[ RUN      ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard
[       OK ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard (913 ms)
[ RUN      ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer
[       OK ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer (599 ms)
[ RUN      ] DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning
[       OK ] DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning (5163 ms)
[ RUN      ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS
[       OK ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS (4963 ms)
[----------] 24 tests from DockerContainerizerTest (89936 ms total)

[----------] 1 test from HungDockerTest
[ RUN      ] HungDockerTest.ROOT_DOCKER_InspectHungDuringPull

d:\dcos\mesos\mesos\src\tests\mock_docker.hpp(155): ERROR: this mock object (used in test
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never is. Its address
is @00000008108FB960.
d:\dcos\mesos\mesos\src\tests\containerizer\docker_containerizer_tests.cpp(5187): ERROR: this
mock object (used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted
but never is. Its address is @00000008108FBBC0.
d:\dcos\mesos\mesos\src\tests\mock_registrar.cpp(54): ERROR: this mock object (used in test
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never is. Its address
is @0000014C98866680.
d:\dcos\mesos\mesos\3rdparty\libprocess\include\process\gmock.hpp(235): ERROR: this mock object
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never
is. Its address is @0000014C98C854B8.
d:\dcos\mesos\mesos\src\tests\mock_docker.cpp(48): ERROR: this mock object (used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull)
should be deleted but never is. Its address is @0000014C99170A90.
ERROR: 5 leaked mock objects found at program exit.
```

- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67791/logs/mesos-tests-stderr.log):

```
I0706 19:27:03.735260 13884 authenticatee.cpp:299] Authentication success
I0706 19:27:03.735260 10512 master.cpp:9786] Successfully authenticated principal 'test-principal'
at scheduler-7fe56de8-421d-4831-bfb2-5847cc6584ee@192.10.1.6:61323
I0706 19:27:03.736261 17472 sched.cpp:501] Successfully authenticated with master master@192.10.1.6:61323
I0706 19:27:03.737259 13884 master.cpp:2927] Received SUBSCRIBE call for framework 'default'
at scheduler-7fe56de8-421d-4831-bfb2-5847cc6584ee@192.10.1.6:61323
I0706 19:27:03.738255 13884 master.cpp:2234] Authorizing framework principal 'test-principal'
to receive offers for roles '{ * }'
I0706 19:27:03.738255  9792 master.cpp:3008] Subscribing framework default with checkpointing
disabled and capabilities [ MULTI_ROLE, RESERVATION_REFINEMENT ]
I0706 19:27:03.738255  9792 master.cpp:9977] Adding framework 5722bfda-4b68-4a5e-9340-e84f2971863d-0000
(default) at scheduler-7fe56de8-421d-4831-bfb2-5847cc6584ee@192.10.1.6:61323 with roles {
 } suppressed
I0706 19:27:03.740252  3548 sched.cpp:749] Framework registered with 5722bfda-4b68-4a5e-9340-e84f2971863d-0000
I0706 19:27:03.741246 10512 hierarchical.cpp:299] Added framework 5722bfda-4b68-4a5e-9340-e84f2971863d-0000
E0706 19:27:03.829475 15544 slave.cpp:7289] EXIT with status 1: Failed to perform recovery:
Collect failed: Failed to run 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\test-docker.bat
-H npipe:////./pipe/docker_engine ps -a': exited with status 1; stderr=''C:\Program' is not
recognized as an internal or external command,

operable program or batch file.

'
If recovery failed due to a change in configuration and you want to
keep the current agent id, you might want to change the
`--reconfiguration_policy` flag to a more permissive value.

To restart this agent with a new agent id instead, do as follows:
rm -f C:\Users\jenkins\AppData\Local\Temp\onL3BU\meta\slaves\latest
This ensures that the agent does not recover old live executors.

If you use the Docker containerizer and think that the Docker
daemon state is broken, you can try to clear it. But be careful:
these commands will erase all containers and images from this host,
not just those started by Mesos!
docker kill $(docker ps -q)
docker rm $(docker ps -a -q)
docker rmi $(docker images -q)

Finally, restart the agent.
```

- Mesos Reviewbot Windows


On July 6, 2018, 6:30 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67791/
> -----------------------------------------------------------
> 
> (Updated July 6, 2018, 6:30 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Greg Mann, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-8987
>     https://issues.apache.org/jira/browse/MESOS-8987
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The Mesos master sends a `ShutdownMessage` to an agent if there is an
> authentication or an authorization error during agent (re)registration.
> 
> Upon receipt of this message, the agent kills alls its tasks and commits
> suicide. This means that transient auth errors can lead to whole agents
> being killed along with it's tasks.
> 
> This patch prevents the master from sending a `ShutdownMessage` in these
> cases.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2 
>   src/tests/authentication_tests.cpp bd46cbc6d565ea8f2f6956c0424a76ad58607017 
>   src/tests/master_authorization_tests.cpp 80b9d49ba334b915461ff5d6df6c9f922d7593e3 
> 
> 
> Diff: https://reviews.apache.org/r/67791/diff/4/
> 
> 
> Testing
> -------
> 
> `bin/mesos-tests.sh` on GNU/Linux
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message