mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 67853: Updated build-virtualenv to use Python 3 features.
Date Mon, 09 Jul 2018 15:54:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67853/
-----------------------------------------------------------

(Updated July 9, 2018, 3:54 p.m.)


Review request for mesos, Benjamin Bannier, Kevin Klues, and Till Toenshoff.


Bugs: MESOS-8882
    https://issues.apache.org/jira/browse/MESOS-8882


Repository: mesos


Description
-------

With Python 3, virtualenv is built-in. We thus remove the error
messages if the script is run using Python 3 without virtualenv
installed on the machine. We also use `python` instead of
`virtualenv` to build the virtual environment.

This change also fixes an issue on my computer where running
`build-virtualenv` with Python 3 displayed an error message:
`ModuleNotFoundError: No module named 'nodeenv'`.


Diffs (updated)
-----

  support/build-virtualenv 5fda08187bb92847dba459550313edff756c9e7f 


Diff: https://reviews.apache.org/r/67853/diff/2/

Changes: https://reviews.apache.org/r/67853/diff/1-2/


Testing
-------

Ran `build-virtualenv` with python 2 and 3.


Thanks,

Armand Grillet


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message