mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 67861: Updated json parsing to avoid copying between picojson and stout JSON.
Date Tue, 10 Jul 2018 05:41:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67861/#review205893
-----------------------------------------------------------




3rdparty/stout/include/stout/json.hpp
Lines 343-347 (original), 352-377 (patched)
<https://reviews.apache.org/r/67861/#comment288785>

    While we're here, we could also replace these with the pointer versions of `boost::get`.
We might get some better performance: https://godbolt.org/g/B84cLb


- Michael Park


On July 9, 2018, 6:40 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67861/
> -----------------------------------------------------------
> 
> (Updated July 9, 2018, 6:40 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When looking at some profiling data, it looks as though we approximately
> double the cost of JSON parsing due to having to convert from
> `picojson::value` to `JSON::Value`.
> 
> Michael Park pointed me to the parsing "context" that's customizable in
> picojson. This patch replaces our conversion with a parsing context in
> order to parse directly into JSON::Value and avoid copying.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/json.hpp c374e29829e4ea02ab3a8494b6ab28c166579516 
> 
> 
> Diff: https://reviews.apache.org/r/67861/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message