mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 67504: Added helper for posting the result of a build
Date Tue, 10 Jul 2018 12:26:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67504/#review205906
-----------------------------------------------------------



The commit message should be edited to finish with a period and the Testing Done part should
be filled even if it's just to say that tests have been done later in the chain.


support/python3/post-build-result.py
Lines 20 (patched)
<https://reviews.apache.org/r/67504/#comment288808>

    Missing period.



support/python3/post-build-result.py
Lines 33 (patched)
<https://reviews.apache.org/r/67504/#comment288809>

    Missing period.



support/python3/post-build-result.py
Lines 47 (patched)
<https://reviews.apache.org/r/67504/#comment288815>

    Put the final space at the beginning of the second line instead.



support/python3/post-build-result.py
Lines 50 (patched)
<https://reviews.apache.org/r/67504/#comment288814>

    Put the final space at the beginning of the second line instead.



support/python3/post-build-result.py
Lines 53 (patched)
<https://reviews.apache.org/r/67504/#comment288813>

    Put the final space at the beginning of the second line instead.



support/python3/post-build-result.py
Lines 61 (patched)
<https://reviews.apache.org/r/67504/#comment288816>

    s/`Method to retrieve`/`Retrieves`.



support/python3/post-build-result.py
Lines 67 (patched)
<https://reviews.apache.org/r/67504/#comment288810>

    Just use `if applied_reviews:`.



support/python3/post-build-result.py
Lines 69 (patched)
<https://reviews.apache.org/r/67504/#comment288811>

    Just use `if failed_command:`.



support/python3/post-build-result.py
Lines 71 (patched)
<https://reviews.apache.org/r/67504/#comment288812>

    Put the final space at the beginning of the second line instead.



support/python3/post-build-result.py
Lines 92 (patched)
<https://reviews.apache.org/r/67504/#comment288817>

    s/`Main method to post`/`Posts`.


- Armand Grillet


On June 14, 2018, 11:13 p.m., Dragos Schebesch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67504/
> -----------------------------------------------------------
> 
> (Updated June 14, 2018, 11:13 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added helper for posting the result of a build
> 
> 
> Diffs
> -----
> 
>   support/python3/post-build-result.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67504/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dragos Schebesch
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message