mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse
Date Tue, 10 Jul 2018 12:49:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67505/#review205907
-----------------------------------------------------------



The commit message should be edited to finish with a period and the Testing Done part needz
to be filled so that we know what tests have been done to check that this chain works.


support/python3/verify-reviews.py
Line 36 (original), 36 (patched)
<https://reviews.apache.org/r/67505/#comment288830>

    Unused import.



support/python3/verify-reviews.py
Lines 52 (patched)
<https://reviews.apache.org/r/67505/#comment288824>

    A comment to say where is this from would be useful.



support/python3/verify-reviews.py
Lines 56 (patched)
<https://reviews.apache.org/r/67505/#comment288818>

    Missing period.



support/python3/verify-reviews.py
Lines 64 (patched)
<https://reviews.apache.org/r/67505/#comment288820>

    Put the final space at the beginning of the next line instead.



support/python3/verify-reviews.py
Lines 73 (patched)
<https://reviews.apache.org/r/67505/#comment288821>

    Put the final space at the beginning of the next line instead.



support/python3/verify-reviews.py
Lines 75 (patched)
<https://reviews.apache.org/r/67505/#comment288819>

    The spacing is wrong.



support/python3/verify-reviews.py
Lines 81 (patched)
<https://reviews.apache.org/r/67505/#comment288822>

    Put the final space at the beginning of the next line instead.



support/python3/verify-reviews.py
Lines 84 (patched)
<https://reviews.apache.org/r/67505/#comment288823>

    Put the final space at the beginning of the next line instead.



support/python3/verify-reviews.py
Line 137 (original), 121 (patched)
<https://reviews.apache.org/r/67505/#comment288831>

    Remove trailing space.



support/python3/verify-reviews.py
Line 138 (original), 122 (patched)
<https://reviews.apache.org/r/67505/#comment288829>

    s/`ReviewBoardHandler`/`ReviewBoardHandler()`.



support/python3/verify-reviews.py
Line 254 (original), 240 (patched)
<https://reviews.apache.org/r/67505/#comment288828>

    We need a docstring for this function.



support/python3/verify-reviews.py
Line 256 (original), 242 (patched)
<https://reviews.apache.org/r/67505/#comment288826>

    s/`There are %s review requests that need verification`/`%s review requests need verification`.



support/python3/verify-reviews.py
Lines 284 (patched)
<https://reviews.apache.org/r/67505/#comment288825>

    Put the final space at the beginning of the next line instead.


- Armand Grillet


On June 14, 2018, 11:13 p.m., Dragos Schebesch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67505/
> -----------------------------------------------------------
> 
> (Updated June 14, 2018, 11:13 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Refactored verify-reviews.py to use commons.py and argparse
> 
> 
> Diffs
> -----
> 
>   support/python3/verify-reviews.py 2e925908ffb59dbcdfe99691c5bdbc36a3b7d855 
> 
> 
> Diff: https://reviews.apache.org/r/67505/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dragos Schebesch
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message