mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 67730: Made Git normalize all line endings automatically.
Date Tue, 10 Jul 2018 19:14:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67730/#review205928
-----------------------------------------------------------



PASS: Mesos patch 67730 was successfully built and tested.

Reviews applied: `['67730']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1896/mesos-review-67730

- Mesos Reviewbot Windows


On July 10, 2018, 5:32 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67730/
> -----------------------------------------------------------
> 
> (Updated July 10, 2018, 5:32 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Joseph Wu, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Instead of relying on the user to `core.autocrlf = true` before
> cloning, we now set this in `.gitattributes` for all files.
> 
> Only one file needed normalization via `git add --renormalize .`, it
> was `site/doap.rdf`.
> 
> The Windows instructions were updated to remove the note about setting
> autocrlf globally, and the outdated note to use Python 2 was updated
> while we were in the file.
> 
> 
> Diffs
> -----
> 
>   .gitattributes PRE-CREATION 
>   docs/windows.md 86b9fe31b2036060c6fbfb080fc7981a943759bb 
>   site/doap.rdf ce23184de617e4f4cd82018d5847561dd84a3865 
> 
> 
> Diff: https://reviews.apache.org/r/67730/diff/3/
> 
> 
> Testing
> -------
> 
> This RR is the test since it'll trigger the currently broken review bot.
> 
> Also see https://git-scm.com/docs/gitattributes
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message