mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Review Request 67883: Windows: Explicitly cast to `SOCKET`/`HANDLE` where appropriate.
Date Thu, 12 Jul 2018 19:10:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67883/
-----------------------------------------------------------

Review request for mesos, Akash Gupta, John Kordich, Joseph Wu, and Radhika Jandhyala.


Repository: mesos


Description
-------

Windows: Explicitly cast to `SOCKET`/`HANDLE` where appropriate.


Diffs
-----

  3rdparty/libprocess/include/process/network.hpp 8f48a4a78557309a9b1b00d7defb45eed454b077

  3rdparty/libprocess/include/process/socket.hpp 4f0f6e9aa6e95e826e3de96e518a7200ad7a8f83

  3rdparty/libprocess/src/posix/libevent/libevent_poll.cpp 038dde2b476a6806c5b5de949387d6b3b8626466

  3rdparty/libprocess/src/posix/poll_socket.cpp 74acb6942682a9d9626df81b303eba0a1c24ecf7 
  3rdparty/libprocess/src/process.cpp b3bd0286e09dcb9d0867679c6a509c34e309a72e 
  3rdparty/libprocess/src/tests/io_tests.cpp d1a7463bae65017d92713513b0a58a0d00d78940 
  3rdparty/libprocess/src/tests/test_linkee.cpp cc482717290f72a5fd95fe745ac01893c0ce41f8 
  3rdparty/libprocess/src/windows/io.cpp 1f9adde36192b673d7051549295a0f403be8e718 
  3rdparty/libprocess/src/windows/libwinio.cpp 85ee7ea3e148ae26f2374918ed7c853a50b3b6c1 
  3rdparty/libprocess/src/windows/poll_socket.cpp 565b0088dc2b270193e615655f57f48419eb2c12



Diff: https://reviews.apache.org/r/67883/diff/1/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message