mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 67779: Introduced `CREATE_DISK` and `DESTROY_DISK` operations.
Date Thu, 12 Jul 2018 20:13:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67779/
-----------------------------------------------------------

(Updated July 12, 2018, 8:13 p.m.)


Review request for mesos, Benjamin Bannier, Gastón Kleiman, Greg Mann, James DeFelice, and
Jie Yu.


Changes
-------

Fixed a typo.


Bugs: MESOS-9066
    https://issues.apache.org/jira/browse/MESOS-9066


Repository: mesos


Description
-------

This patch introduces `CREATE_DISK` and `DESTROY_DISK` operations for
conversion between RAW disk resaurces and MOUNT/BLOCK disk resources to
replace `CREATE_VOLUME`/`DESTROY_VOLUME`/`CREATE_BLOCK`/`DESTROY_BLOCK`.

This replacement involves two aspects:

1. Renaming: The term "volume" is overloaded and created name conflicts
   in mesos. This renaming would lead to cleaner names in ACL and other
   places, and is more consistent with CSI.

2. Removing PATH support. PATH disks are used to split a disk resource
   into smaller chunks for concurrent independent uses. However, this
   concept does not quite fit CSI well.


Diffs (updated)
-----

  include/mesos/mesos.proto 463e6adcdf14115b2f21270bb1fd9c45e1b67cc3 
  include/mesos/v1/mesos.proto 8eaad9c4b2a9cdd527922a004b0f7dd0dc58a7f1 


Diff: https://reviews.apache.org/r/67779/diff/4/

Changes: https://reviews.apache.org/r/67779/diff/3-4/


Testing
-------

Test done later in chain.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message