mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 67900: Fixed compilation error with `DispatchProcess` code.
Date Thu, 12 Jul 2018 23:44:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67900/
-----------------------------------------------------------

(Updated July 12, 2018, 4:44 p.m.)


Review request for mesos, Benjamin Mahler, Joseph Wu, and Michael Park.


Changes
-------

Added comment and clarified commit message.


Bugs: MESOS-8686
    https://issues.apache.org/jira/browse/MESOS-8686


Repository: mesos


Description (updated)
-------

Per MESOS-8686 and MESOS-8915, the benchmark test
`ProcessTest.Process_BENCHMARK_DispatchDefer` had been disabled on
Windows as the `DispatchProcess` class no longer compiled with
`/permissive-` using the latest version of MSVC. The fix is thanks to
PhoebeHui.


Diffs (updated)
-----

  3rdparty/libprocess/src/tests/benchmarks.cpp 604122a2f33d7abfab92631d9eac33b6753e846b 


Diff: https://reviews.apache.org/r/67900/diff/2/

Changes: https://reviews.apache.org/r/67900/diff/1-2/


Testing
-------

On Windows:

```
> .\3rdparty\libprocess\src\tests\benchmarks.exe
[==========] Running 5 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 5 tests from ProcessTest
[ RUN      ] ProcessTest.Process_BENCHMARK_ClientServer
Client 0: 117669 rpcs / sec
Client 1: 116301 rpcs / sec
Client 2: 116301 rpcs / sec
Client 3: 117649 rpcs / sec
Client 4: 116280 rpcs / sec
Client 5: 116280 rpcs / sec
Client 6: 117648 rpcs / sec
Client 7: 117648 rpcs / sec
Estimated Total: 888900 rpcs / sec
[       OK ] ProcessTest.Process_BENCHMARK_ClientServer (107 ms)
[ RUN      ] ProcessTest.Process_BENCHMARK_LargeNumberOfLinks
Elapsed: 80.0271ms
[       OK ] ProcessTest.Process_BENCHMARK_LargeNumberOfLinks (273 ms)
[ RUN      ] ProcessTest.Process_BENCHMARK_ThroughputPerformance
Estimated Total: 6714374.836421
[       OK ] ProcessTest.Process_BENCHMARK_ThroughputPerformance (2235 ms)
[ RUN      ] ProcessTest.Process_BENCHMARK_DispatchDefer
Movable elapsed: 847.036100000000033ms
Copyable elapsed: 1.337995300000000secs
[       OK ] ProcessTest.Process_BENCHMARK_DispatchDefer (2189 ms)
[ RUN      ] ProcessTest.Process_BENCHMARK_ProtobufInstallHandler
Size:     4 bytes, throughput:   3388581 messages/s
Size:    10 bytes, throughput:   2395662 messages/s
Size:    34 bytes, throughput:   1343124 messages/s
Size:    64 bytes, throughput:   1000243 messages/s
Size:   304 bytes, throughput:    329189 messages/s
Size:   605 bytes, throughput:    178676 messages/s
Size:  3011 bytes, throughput:     40253 messages/s
Size:  6019 bytes, throughput:     19969 messages/s
Size: 30081 bytes, throughput:      4015 messages/s
Size: 60160 bytes, throughput:      1993 messages/s
[       OK ] ProcessTest.Process_BENCHMARK_ProtobufInstallHandler (10027 ms)
[----------] 5 tests from ProcessTest (14833 ms total)

[----------] Global test environment tear-down
[==========] 5 tests from 1 test case ran. (14837 ms total)
[  PASSED  ] 5 tests.
```


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message