mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 67907: Updated pylint usage in mesos-style.py to be less verbose.
Date Fri, 13 Jul 2018 12:51:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67907/#review206048
-----------------------------------------------------------



PASS: Mesos patch 67907 was successfully built and tested.

Reviews applied: `['67907']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1917/mesos-review-67907

- Mesos Reviewbot Windows


On July 13, 2018, 11:20 a.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67907/
> -----------------------------------------------------------
> 
> (Updated July 13, 2018, 11:20 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Kevin Klues.
> 
> 
> Bugs: MESOS-9074
>     https://issues.apache.org/jira/browse/MESOS-9074
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We use Pylint 1.9 since a few days to lint `.py` files, this version
> prints a score after linting. To make the output less verbose, we now
> use the option `--score=n` when using pylint in mesos-style.py.
> 
> 
> Diffs
> -----
> 
>   support/mesos-style.py 27ed553cb1d9e0c3c750b414eafe0144c3442c43 
>   support/python3/mesos-style.py 350ef909e3e7a1c927140cf4475547d704ac2ad5 
> 
> 
> Diff: https://reviews.apache.org/r/67907/diff/1/
> 
> 
> Testing
> -------
> 
> Before:
> ```
> apache-mesos (MESOS-9073) $ git commit -m "Test."
> No C++ files to lint
> No JavaScript files to lint
> Checking 1 Python file
> Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
> 
> -------------------------------------------------------------------
> Your code has been rated at 10.00/10 (previous run: 9.22/10, +0.78)
> 
> Total errors found: 0
> [MESOS-9073 a3509d402] Test.
>  1 file changed, 1 insertion(+), 1 deletion(-)
> ```
> 
> After:
> ```
> apache-mesos (MESOS-9073) $ git commit -m "Test."
> No C++ files to lint
> No JavaScript files to lint
> Checking 1 Python file
> Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
> Total errors found: 0
> [MESOS-9073 a3509d402] Test.
>  1 file changed, 1 insertion(+), 1 deletion(-)
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message