mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Review Request 67910: Fixed virtualenv management in support directory.
Date Fri, 13 Jul 2018 16:22:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67910/
-----------------------------------------------------------

Review request for mesos and Kevin Klues.


Bugs: MESOS-9075
    https://issues.apache.org/jira/browse/MESOS-9075


Repository: mesos


Description
-------

The switch from Python 2 to Python 3 creates problems regarding the
virtual environment if a developer dangles between Python 2 and 3 as
we want the virtual environment to use the same version of Python as
the user to give useful logs when linting.

This commit fixes the issue by adding a new check in the function of
`mesos-style.py` called `should_build_virtualenv` to see if the Python
interpreter version currently used is the one in the virtual
environement. If not, the virtual environment will get recreated.

A second issue was that running `build-virtualenv` with Python 3
then again with Python 2 would end up with two versions of Python
in the virtualenv and continue to use Python 3 in that environment.
This is due to an old issue of `virtualenv` that we now handle by
removing the entire virtual environment before building it again.


Diffs
-----

  support/build-virtualenv b8dc1d98f97bc70d9f7099db2c9cb85a884be12c 
  support/mesos-style.py 27ed553cb1d9e0c3c750b414eafe0144c3442c43 
  support/python3/mesos-style.py 350ef909e3e7a1c927140cf4475547d704ac2ad5 


Diff: https://reviews.apache.org/r/67910/diff/1/


Testing
-------

Run the two `mesos-style.py` and `build-virtualenv` with `MESOS_SUPPORT_PYTHON` set to 3 or
not. Checked that the python intepreter installed in the virtual environment was correct.


Thanks,

Armand Grillet


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message