mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 67892: Made disk type checks in SLRP hard assertions.
Date Fri, 13 Jul 2018 18:39:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67892/
-----------------------------------------------------------

(Updated July 13, 2018, 6:39 p.m.)


Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.


Changes
-------

Rebased.


Bugs: MESOS-9066
    https://issues.apache.org/jira/browse/MESOS-9066


Repository: mesos


Description
-------

Since the disk types of the `CREATE_DISK` and `DESTROY_DISK` should have
been validated by the master, we now use `CHECK`s instead of returning
failures.


Diffs (updated)
-----

  src/resource_provider/storage/provider.cpp b90a4b81838fec410a97a10ce44a811bb81c87eb 


Diff: https://reviews.apache.org/r/67892/diff/2/

Changes: https://reviews.apache.org/r/67892/diff/1-2/


Testing
-------

Tests done later in chain.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message