mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 67911: Fixed `build-virtualenv` to correctly clear virtual environment.
Date Fri, 13 Jul 2018 20:02:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67911/#review206071
-----------------------------------------------------------


Ship it!




Ship It!

- Kevin Klues


On July 13, 2018, 4:37 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67911/
> -----------------------------------------------------------
> 
> (Updated July 13, 2018, 4:37 p.m.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Bugs: MESOS-9075
>     https://issues.apache.org/jira/browse/MESOS-9075
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Running `build-virtualenv` with Python 3 then again with Python 2
> lets the directory with two versions of Python in the virtualenv
> and Python 3 is then still used in that environment.
> 
> This is due to an old issue of `virtualenv` that we now handle by
> removing the support virtualenv directory before building it again.
> 
> 
> Diffs
> -----
> 
>   support/build-virtualenv b8dc1d98f97bc70d9f7099db2c9cb85a884be12c 
> 
> 
> Diff: https://reviews.apache.org/r/67911/diff/1/
> 
> 
> Testing
> -------
> 
> Run `PYTHON=python3 build-virtualenv` then `build-virtualenv` then checked `.virtualenv`
content.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message