mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Review Request 67916: Patched Google Test with upstream bugfix.
Date Fri, 13 Jul 2018 21:04:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67916/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier, Joseph Wu, and Till Toenshoff.


Bugs: MESOS-8990
    https://issues.apache.org/jira/browse/MESOS-8990


Repository: mesos


Description
-------

Per MESOS-8990, our Google Test dependency needs a patch from
upstream, https://github.com/google/googletest/pull/1620, in order to
continue building with the next version of MSVC (and potentially other
compilers).

This patch file was generated by cherry-picking `f66ab00` from
`master` onto `release-1.8.0` in the Google Test repo, and resolving
the merge conflict.


Diffs
-----

  3rdparty/CMakeLists.txt b58996d2ed7521e42d6298d174cc8c494b84eb8f 
  3rdparty/googletest-release-1.8.0.patch PRE-CREATION 


Diff: https://reviews.apache.org/r/67916/diff/1/


Testing
-------

Clean build on Windows using CMake (which is the only place this patch currently applies).
It is not yet known if the Autotools system will also need this patch. Do we want it added
there anyway?


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message