mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 67933: Replaced `<stout/windows/os.hpp>` with `<stout/os.hpp>` in stout.
Date Mon, 16 Jul 2018 23:16:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67933/#review206136
-----------------------------------------------------------



PASS: Mesos patch 67933 was successfully built and tested.

Reviews applied: `['67933']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1937/mesos-review-67933

- Mesos Reviewbot Windows


On July 16, 2018, 9:43 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67933/
> -----------------------------------------------------------
> 
> (Updated July 16, 2018, 9:43 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, John Kordich, Joseph Wu, and Radhika Jandhyala.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The intent is that `os.hpp` includes the correct OS-specific header,
> `windows/os.hpp` or `posix/os.hpp`, automatically. They should never
> be included manually.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/windows/kill.hpp bd944357bd741d62aea78c839d87b80853e4a852

>   3rdparty/stout/include/stout/os/windows/rm.hpp 1c66e3e6fa20116866842378077e10052c147289

>   3rdparty/stout/include/stout/windows/net.hpp d70f967773d23672f53dd7dd6123434f5e81eeb0

> 
> 
> Diff: https://reviews.apache.org/r/67933/diff/1/
> 
> 
> Testing
> -------
> 
> Old patch I found on my computer that I figured I should post. `ninja tests ; ctest -V`
on Windows.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message