mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 67936: Fixed ephemeral ports deallocation in network/port_mapping isolator.
Date Tue, 17 Jul 2018 00:46:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67936/#review206141
-----------------------------------------------------------



PASS: Mesos patch 67936 was successfully built and tested.

Reviews applied: `['67936']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1939/mesos-review-67936

- Mesos Reviewbot Windows


On July 16, 2018, 11:14 p.m., Ilya Pronin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67936/
> -----------------------------------------------------------
> 
> (Updated July 16, 2018, 11:14 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-9080
>     https://issues.apache.org/jira/browse/MESOS-9080
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ephemeral ports are allocated for a container during the preparation
> phase and have to be deallocated during container cleanup regardless of
> whether the container process was isolated or not. Otherwise those ports
> can be leaked if the container is destroyed during preparation.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp a29282ed0488d83966f222084031ed1d2b6ab1f5

>   src/tests/containerizer/port_mapping_tests.cpp 553f53043a52cfe235fc2b2e88fb54d0f2725d3e

> 
> 
> Diff: https://reviews.apache.org/r/67936/diff/1/
> 
> 
> Testing
> -------
> 
> Added `PortMappingIsolatorTest.ROOT_CleanupNotIsolated` test to verify that ephemeral
ports are properly deallocated when the container was not isolated and manually checked that
if fails without the fix. Ran `sudo make check`.
> 
> 
> Thanks,
> 
> Ilya Pronin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message