mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Review Request 67952: Windows: Ported remaining tests in the `HTTPTest` suite.
Date Tue, 17 Jul 2018 22:27:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67952/
-----------------------------------------------------------

Review request for mesos, Eric Mumau, John Kordich, Joseph Wu, Liangyu Zhao, and Radhika Jandhyala.


Bugs: MESOS-5904 and MESOS-8564
    https://issues.apache.org/jira/browse/MESOS-5904
    https://issues.apache.org/jira/browse/MESOS-8564


Repository: mesos


Description
-------

These were enabled by fixing the use of `Path()` in `process.cpp` to
explicitly use '/' as the separator, as it's being used to manipulate
URLs, not filesystem paths, and previously this failed due the Windows
path separator being '\'.


Diffs
-----

  3rdparty/libprocess/src/process.cpp 7c0a0bc0c1e50354b6da219032ac830cbeec0a0d 
  3rdparty/libprocess/src/tests/http_tests.cpp acbd6973829411652fc5d57ef473c0d8ba9cd5b4 


Diff: https://reviews.apache.org/r/67952/diff/1/


Testing
-------

`stout-tests` and `libprocess-tests` passed on Windows and Ubuntu


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message