mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 67953: Disabled the clang `-Winconsistent-missing-override` warning.
Date Wed, 18 Jul 2018 02:25:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67953/#review206189
-----------------------------------------------------------



PASS: Mesos patch 67953 was successfully built and tested.

Reviews applied: `['67953']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1948/mesos-review-67953

- Mesos Reviewbot Windows


On July 18, 2018, 12:05 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67953/
> -----------------------------------------------------------
> 
> (Updated July 18, 2018, 12:05 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Clang can emit a `-Winconsistent-missing-override` warning for most
> uses of the Google Mock `MOCK_METHOD` family of macros. See also
> https://github.com/google/googletest/issues/533.
> 
> 
> Diffs
> -----
> 
>   cmake/CompilationConfigure.cmake 49b2dc0deec939e4c61b39c91bc5be4765fee194 
>   configure.ac 5f64168ce8867b23f0aed20f30682ebd35711ceb 
> 
> 
> Diff: https://reviews.apache.org/r/67953/diff/1/
> 
> 
> Testing
> -------
> 
> make (Fedora 28)
> cmake (Fedora 28)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message