mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 67896: Added container-specific cgroups mount for freezer & systemd subsystems.
Date Wed, 18 Jul 2018 22:46:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67896/#review206219
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
Lines 628 (patched)
<https://reviews.apache.org/r/67896/#comment289109>

    Should we also use `CGROUP_SEPARATOR` and move it to a common place?



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
Lines 645 (patched)
<https://reviews.apache.org/r/67896/#comment289110>

    ditto.


- Gilbert Song


On July 12, 2018, 7:16 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67896/
> -----------------------------------------------------------
> 
> (Updated July 12, 2018, 7:16 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-9070
>     https://issues.apache.org/jira/browse/MESOS-9070
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added container-specific cgroups mount for freezer & systemd subsystems.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 8fba6f9d335cc43a7cd0fcb51ed047ba0e7027ed

> 
> 
> Diff: https://reviews.apache.org/r/67896/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message