mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 67896: Added container-specific cgroups mount for freezer & systemd subsystems.
Date Thu, 19 Jul 2018 08:39:51 GMT


> On July 19, 2018, 6:46 a.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
> > Lines 628 (patched)
> > <https://reviews.apache.org/r/67896/diff/1/?file=2058953#file2058953line628>
> >
> >     Should we also use `CGROUP_SEPARATOR` and move it to a common place?

Agree, let me move it to `src/slave/containerizer/mesos/constants.hpp`.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67896/#review206219
-----------------------------------------------------------


On July 12, 2018, 10:16 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67896/
> -----------------------------------------------------------
> 
> (Updated July 12, 2018, 10:16 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-9070
>     https://issues.apache.org/jira/browse/MESOS-9070
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added container-specific cgroups mount for freezer & systemd subsystems.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 8fba6f9d335cc43a7cd0fcb51ed047ba0e7027ed

> 
> 
> Diff: https://reviews.apache.org/r/67896/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message