mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 67956: Removed some generic flag parsers that are now in stout.
Date Thu, 19 Jul 2018 19:52:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67956/#review206247
-----------------------------------------------------------


Ship it!




I assume removing these in this commit seprate from adding them to stout in the previous commit
didn't cause build errors, for the short time between commits when there were duplicate definitions
of them?

- Kevin Klues


On July 18, 2018, 1:19 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67956/
> -----------------------------------------------------------
> 
> (Updated July 18, 2018, 1:19 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed some generic flag parsers that are now in stout.
> 
> 
> Diffs
> -----
> 
>   src/common/parse.hpp 03814e3112a043a1001764b316b9d49501d33665 
> 
> 
> Diff: https://reviews.apache.org/r/67956/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message