mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 67995: Normalized paths passed to mesos-style.
Date Fri, 20 Jul 2018 07:08:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67995/#review206261
-----------------------------------------------------------


Ship it!




Ship It!

- Armand Grillet


On juil. 20, 2018, 7:07 matin, Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67995/
> -----------------------------------------------------------
> 
> (Updated juil. 20, 2018, 7:07 matin)
> 
> 
> Review request for mesos, Armand Grillet and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This make it possible to pass in slightly messier paths to
> mesos-style, e.g., paths containing double directory separators.
> 
> 
> Diffs
> -----
> 
>   support/mesos-style.py 4f3488cadfe01b0969977171fb40bbc7ad840bc2 
>   support/python3/mesos-style.py cba47c3a60ca47c9d2059574f3f6761b6361a734 
> 
> 
> Diff: https://reviews.apache.org/r/67995/diff/1/
> 
> 
> Testing
> -------
> 
> Before this patch the following invocations lint nothing
> 
> * `./support/mesos-style.py ./support/mesos-style.py`
> * `./support/mesos-style.py support//mesos-style.py`
> 
> After this patch they both successfully (claim to) lint the file.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message