mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 67998: Improved cmake missing files check script.
Date Fri, 20 Jul 2018 11:41:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67998/#review206280
-----------------------------------------------------------



PASS: Mesos patch 67998 was successfully built and tested.

Reviews applied: `['67998']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1964/mesos-review-67998

- Mesos Reviewbot Windows


On July 20, 2018, 10:08 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67998/
> -----------------------------------------------------------
> 
> (Updated July 20, 2018, 10:08 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Andrew Schwartzmeyer.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch performs some cleanups:
> 
> * do not emit `realpath` errors when validating filename-like strings
>   in the cmake build,
> * prevent stray output of log headings when no issues were found,
> * emit all diagnostics to stderr,
> * return with an error code if issues were found.
> 
> 
> Diffs
> -----
> 
>   support/check-cmake-missing-files.sh b17e8715eb0ceb0c82d87372e2b756741ad6a7e9 
> 
> 
> Diff: https://reviews.apache.org/r/67998/diff/1/
> 
> 
> Testing
> -------
> 
> Checked output before and after https://reviews.apache.org/r/67751/.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message