mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 67983: Enabled `TimeTest.Now` on Windows.
Date Tue, 24 Jul 2018 11:50:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67983/#review206384
-----------------------------------------------------------



Patch looks great!

Reviews applied: [67951, 67952, 67976, 67977, 67978, 67979, 67980, 67983]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On July 20, 2018, 5:19 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67983/
> -----------------------------------------------------------
> 
> (Updated July 20, 2018, 5:19 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, Liangyu Zhao,
and Radhika Jandhyala.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> While the timer resolution on Windows does not support 10
> microseconds, it does support 1000 microseconds, which is still fast
> enough for a unit test.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/time_tests.cpp 08ddb56f1789f400b8cd072c53e885c759f13ddc

> 
> 
> Diff: https://reviews.apache.org/r/67983/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message