mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dario Rexin <da...@mesosphere.io>
Subject Re: Review Request 68001: Fix padding in MpscLinkedQueue.
Date Tue, 24 Jul 2018 14:59:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68001/
-----------------------------------------------------------

(Updated July 24, 2018, 2:59 p.m.)


Review request for Benjamin Bannier and James Peach.


Repository: mesos


Description
-------

This patch aligns the head of MpscLinkedQueue to a new cache line
and adds padding between head and tail to avoid false sharing
between to two and after tail to avoid false sharing with other
objects that could otherwise end up on the same cache line.


Diffs (updated)
-----

  3rdparty/libprocess/src/mpsc_linked_queue.hpp 48c95093d 


Diff: https://reviews.apache.org/r/68001/diff/2/

Changes: https://reviews.apache.org/r/68001/diff/1-2/


Testing
-------

make check & benchmarks


Thanks,

Dario Rexin


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message