mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 67827: Added a helper `stripIncapableResources` in the allocator.
Date Tue, 24 Jul 2018 19:58:09 GMT


> On July 23, 2018, 4:19 p.m., Benjamin Mahler wrote:
> > src/master/allocator/mesos/hierarchical.hpp
> > Lines 685 (patched)
> > <https://reviews.apache.org/r/67827/diff/3/?file=2061977#file2061977line685>
> >
> >     const Resources& per comment below

Done.


> On July 23, 2018, 4:19 p.m., Benjamin Mahler wrote:
> > src/master/allocator/mesos/hierarchical.cpp
> > Lines 1812-1813 (original), 1812-1813 (patched)
> > <https://reviews.apache.org/r/67827/diff/3/?file=2061978#file2061978line1812>
> >
> >     What is "normal offer behavior"? In this patch we can just adjust the comment
to reflect that we're not doing an explicit copy anymore, and if we want to document *why*
the current approach is used, we can do that in a separate patch after hearing from Yan?

Commented why we are subtracting already offered resources in this cycle.


> On July 23, 2018, 4:19 p.m., Benjamin Mahler wrote:
> > src/master/allocator/mesos/hierarchical.cpp
> > Lines 2044-2047 (original), 2024-2027 (patched)
> > <https://reviews.apache.org/r/67827/diff/3/?file=2061978#file2061978line2044>
> >
> >     Ditto here.

Commented why we are subtracting already offered resources in this cycle.


> On July 23, 2018, 4:19 p.m., Benjamin Mahler wrote:
> > src/master/allocator/mesos/hierarchical.cpp
> > Lines 2689 (patched)
> > <https://reviews.apache.org/r/67827/diff/3/?file=2061978#file2061978line2734>
> >
> >     This can be `const Resources&` to avoid a copy?

Done.


- Meng


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67827/#review206365
-----------------------------------------------------------


On July 24, 2018, 12:58 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67827/
> -----------------------------------------------------------
> 
> (Updated July 24, 2018, 12:58 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9104
>     https://issues.apache.org/jira/browse/MESOS-9104
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This helper removes any resources that the framework is not
> capable of receiving based on the given framework capability.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp c1a6789f1808a57dd94ede7bbd2636031f136ea3

>   src/master/allocator/mesos/hierarchical.cpp 7b4e9db3435b51c9ce025b7b522e10db4b907ebb

> 
> 
> Diff: https://reviews.apache.org/r/67827/diff/4/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message