mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dario Rexin <da...@mesosphere.io>
Subject Re: Review Request 68039: Padded using the type name in `MpscLinkedQueue`.
Date Wed, 25 Jul 2018 19:56:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68039/#review206461
-----------------------------------------------------------


Ship it!




Ship It!

- Dario Rexin


On July 25, 2018, 2:42 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68039/
> -----------------------------------------------------------
> 
> (Updated July 25, 2018, 2:42 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, and Dario Rexin.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The Windows build doesn't accept the name of the `tail` member
> variable when defining the padding, so use the type name instead.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/mpsc_linked_queue.hpp 0036eb8d6c0a8dc6f78dc552c8f5500305985172

> 
> 
> Diff: https://reviews.apache.org/r/68039/diff/1/
> 
> 
> Testing
> -------
> 
> None (waiting for reviewbot)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message