mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 68054: Added networking statistics to cni isolator.
Date Fri, 27 Jul 2018 19:38:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68054/#review206551
-----------------------------------------------------------



Patch looks great!

Reviews applied: [68052, 68053, 68054]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On July 25, 2018, 10:42 p.m., Sergey Urbanovich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68054/
> -----------------------------------------------------------
> 
> (Updated July 25, 2018, 10:42 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-5647
>     https://issues.apache.org/jira/browse/MESOS-5647
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> On receiving a request for getting `usage` for a given container
> the `network/cni` isolator uses getifaddrs(3) glibc function. The
> function returns basic networking metrics for each networking
> interface in the container networking namespace. It should work
> right out of the box on all modern Linux-based systems.
> 
> To get more networking metrics please use Netlink Protocol Library.
> However, you will have to open NETLINK sockets in each networking
> namespace and manage them from the `network/cni` isolator.
> 
> JIRA: https://issues.apache.org/jira/browse/MESOS-5647
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 31ec4ddb1049b7259b0784e5e40b002e29f6a8da

>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp f46c962d8f044092aaa113fafc536c6b25bab45c

>   src/tests/containerizer/cni_isolator_tests.cpp 90d2d4103c8136d2dd883318acc135f7efca80d8

> 
> 
> Diff: https://reviews.apache.org/r/68054/diff/1/
> 
> 
> Testing
> -------
> 
> bin/mesos-tests.sh --verbose --gtest_filter="CniIsolatorTest.ROOT_VerifyResourceStatistics"
--gtest_break_on_failure --gtest_repeat=100
> 
> 
> Thanks,
> 
> Sergey Urbanovich
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message