mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 68094: Add port mapping and network ports isolators sources to CMake.
Date Fri, 27 Jul 2018 21:16:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68094/#review206557
-----------------------------------------------------------



FAIL: Mesos binaries failed to build.

Reviews applied: `['67751', '68093', '68094']`

Failed command: `cmake.exe --build . --config Release -- /maxcpucount`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1992/mesos-review-68094

Relevant logs:

- [mesos-binaries-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1992/mesos-review-68094/logs/mesos-binaries-cmake-stdout.log):

```
       "D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) ->
       "D:\DCOS\mesos\src\resource_provider\storage\uri_disk_profile_adaptor.vcxproj" (default
target) (46) ->
         d:\dcos\mesos\mesos\3rdparty\stout\include\stout\exit.hpp(69): warning C4722: '__Exit::~__Exit':
destructor never returns, potential memory leak [D:\DCOS\mesos\src\resource_provider\storage\uri_disk_profile_adaptor.vcxproj]


       "D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) ->
       "D:\DCOS\mesos\src\launcher\mesos-executor.vcxproj" (default target) (39) ->
         d:\dcos\mesos\mesos\3rdparty\stout\include\stout\exit.hpp(69): warning C4722: '__Exit::~__Exit':
destructor never returns, potential memory leak [D:\DCOS\mesos\src\launcher\mesos-executor.vcxproj]


       "D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) ->
       "D:\DCOS\mesos\src\launcher\mesos-fetcher.vcxproj" (default target) (40) ->
         d:\dcos\mesos\mesos\3rdparty\stout\include\stout\exit.hpp(69): warning C4722: '__Exit::~__Exit':
destructor never returns, potential memory leak [D:\DCOS\mesos\src\launcher\mesos-fetcher.vcxproj]


       "D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) ->
       "D:\DCOS\mesos\src\slave\mesos-agent.vcxproj" (default target) (36) ->
         d:\dcos\mesos\mesos\3rdparty\stout\include\stout\exit.hpp(69): warning C4722: '__Exit::~__Exit':
destructor never returns, potential memory leak [D:\DCOS\mesos\src\slave\mesos-agent.vcxproj]


       "D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) ->
       "D:\DCOS\mesos\src\cli\mesos-cli.vcxproj" (default target) (34) ->
       (ClCompile target) -> 
         d:\dcos\mesos\mesos\src\cli\mesos.cpp(17): fatal error C1083: Cannot open include
file: 'unistd.h': No such file or directory [D:\DCOS\mesos\src\cli\mesos-cli.vcxproj]

    411 Warning(s)
    1 Error(s)

Time Elapsed 00:27:20.70
```

- Mesos Reviewbot Windows


On July 27, 2018, 7:11 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68094/
> -----------------------------------------------------------
> 
> (Updated July 27, 2018, 7:11 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, James Peach, and Joseph
Wu.
> 
> 
> Bugs: MESOS-8993 and MESOS-8994
>     https://issues.apache.org/jira/browse/MESOS-8993
>     https://issues.apache.org/jira/browse/MESOS-8994
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This adds the relevant options, but with a fatal message if they're
> used, as we do not yet check for their dependency. This also adds the
> `mesos-network-helper` executable as used by the port mapping
> isolator.
> 
> 
> Diffs
> -----
> 
>   cmake/CompilationConfigure.cmake f80c265d117c70acda95da6b943cdd3e4e477daa 
>   src/CMakeLists.txt 10b0946d6f49c7e9c201bad6f9f1b41cc8460fe5 
>   src/slave/containerizer/mesos/CMakeLists.txt ba1f92fe7dd59c34c6dee0bc7ecf6f1b5160eee8

>   src/tests/CMakeLists.txt 695b6f543847d4270f7004a1768919904975d7a4 
> 
> 
> Diff: https://reviews.apache.org/r/68094/diff/1/
> 
> 
> Testing
> -------
> 
> Pending... There isn't much to test for the isolators added, as they're added with a
fatal bailout. Double-checking that without enabling the new options, everything still works
as expected.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message