mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 68092: CMake: Always build gRPC in Mesos.
Date Sat, 28 Jul 2018 00:53:55 GMT


> On July 27, 2018, 2:08 p.m., Mesos Reviewbot Windows wrote:
> > FAIL: Mesos binaries failed to build.
> > 
> > Reviews applied: `['68091', '68074', '68092']`
> > 
> > Failed command: `cmake.exe --build . --config Release -- /maxcpucount`
> > 
> > All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1993/mesos-review-68092
> > 
> > Relevant logs:
> > 
> > - [mesos-binaries-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1993/mesos-review-68092/logs/mesos-binaries-cmake-stdout.log):
> > 
> > ```
> >          d:\dcos\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0\src\core\lib\iomgr\error_internal.h(56):
warning C4200: nonstandard extension used: zero-sized array in struct/union [D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc_unsecure.vcxproj]
[D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
> >          d:\dcos\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0\src\core\lib\transport\bdp_estimator.cc(35):
warning C4244: 'initializing': conversion from 'double' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc_unsecure.vcxproj]
[D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
> >          d:\dcos\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0\src\core\lib\iomgr\error_internal.h(56):
warning C4200: nonstandard extension used: zero-sized array in struct/union [D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc_unsecure.vcxproj]
[D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
> >          server_posix.obj : warning LNK4221: This object file does not define any
previously undefined public symbols, so it will not be used by any link operation that consumes
this library [D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc++_unsecure.vcxproj]
[D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
> >          rpc_method.obj : warning LNK4221: This object file does not define any
previously undefined public symbols, so it will not be used by any link operation that consumes
this library [D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc++_unsecure.vcxproj]
[D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
> >          create_channel_posix.obj : warning LNK4221: This object file does not define
any previously undefined public symbols, so it will not be used by any link operation that
consumes this library [D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc++_unsecure.vcxproj]
[D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
> >          server_posix.obj : warning LNK4221: This object file does not define any
previously undefined public symbols, so it will not be used by any link operation that consumes
this library [D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc++_unsecure.vcxproj]
[D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
> >          rpc_method.obj : warning LNK4221: This object file does not define any
previously undefined public symbols, so it will not be used by any link operation that consumes
this library [D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc++_unsecure.vcxproj]
[D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
> >          create_channel_posix.obj : warning LNK4221: This object file does not define
any previously undefined public symbols, so it will not be used by any link operation that
consumes this library [D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc++_unsecure.vcxproj]
[D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
> > 
> > 
> >        "D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) ->
> >        "D:\DCOS\mesos\src\slave\resource_estimators\fixed_resource_estimator.vcxproj"
(default target) (4) ->
> >        "D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj" (default target)
(28) ->
> >        (ClCompile target) -> 
> >          d:\dcos\mesos\mesos\3rdparty\stout\include\stout\exit.hpp(69): warning
C4722: '__Exit::~__Exit': destructor never returns, potential memory leak [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
> >          d:\dcos\mesos\mesos\3rdparty\stout\include\stout\exit.hpp(69): warning
C4722: '__Exit::~__Exit': destructor never returns, potential memory leak [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
> > 
> > 
> >        "D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) ->
> >        "D:\DCOS\mesos\src\slave\resource_estimators\fixed_resource_estimator.vcxproj"
(default target) (4) ->
> >        "D:\DCOS\mesos\src\mesos-protobufs.vcxproj" (default target) (22) ->
> >        (CustomBuild target) -> 
> >          C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 1. [D:\DCOS\mesos\src\mesos-protobufs.vcxproj]
> > 
> >     390 Warning(s)
> >     1 Error(s)
> > 
> > Time Elapsed 00:09:09.93
> > ```

In case you are looking for the actual error:
```
Generating ../include/csi/csi.pb.cc, ../include/csi/csi.pb.h, ../include/csi/csi.grpc.pb.cc,
../include/csi/csi.grpc.pb.h
         --grpc_out: protoc-gen-grpc: The system cannot find the path specified.
```


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68092/#review206555
-----------------------------------------------------------


On July 27, 2018, 12:12 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68092/
> -----------------------------------------------------------
> 
> (Updated July 27, 2018, 12:12 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-8395
>     https://issues.apache.org/jira/browse/MESOS-8395
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMake: Always build gRPC in Mesos.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 9b0dfe0ab2187d6d57bb267939aa7c1dbf6c3e8d 
>   cmake/CompilationConfigure.cmake f80c265d117c70acda95da6b943cdd3e4e477daa 
>   src/CMakeLists.txt 10b0946d6f49c7e9c201bad6f9f1b41cc8460fe5 
>   src/cmake/MesosProtobuf.cmake 9fadc9f0616a00f3c30c1fa81a44e0023ccf865f 
>   src/examples/CMakeLists.txt 6a6ee7c3029552ef12726d1c36ccabd8c79ba1f8 
>   src/tests/CMakeLists.txt 695b6f543847d4270f7004a1768919904975d7a4 
> 
> 
> Diff: https://reviews.apache.org/r/68092/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check with CMake
> Built with Ninja
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message