mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.
Date Mon, 30 Jul 2018 22:03:12 GMT


> On July 16, 2018, 12:48 p.m., Mesos Reviewbot Windows wrote:
> > FAIL: Some of the unit tests failed. Please check the relevant logs.
> > 
> > Reviews applied: `['67930', '67931', '67932']`
> > 
> > Failed command: `Start-MesosCITesting`
> > 
> > All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1935/mesos-review-67932
> > 
> > Relevant logs:
> > 
> > - [stout-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1935/mesos-review-67932/logs/stout-tests-cmake-stdout.log):
> > 
> > ```
> >          d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(1056): warning
C4267: '=': conversion from 'size_t' to 'Int32', possible loss of data [D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj]
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
> >          d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(1191): warning
C4267: '=': conversion from 'size_t' to 'Int32', possible loss of data [D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj]
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
> >          d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(1417): warning
C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead.
To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj]
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
> >          d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(1418): warning
C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead.
To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj]
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
> >          d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(1423): warning
C4996: 'setmode': The POSIX name for this item is deprecated. Instead, use the ISO C and C++
conformant name: _setmode. See online help for details. [D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj]
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
> >          d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(1425): warning
C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To
disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj]
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
> >          d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(1431): warning
C4996: 'fdopen': The POSIX name for this item is deprecated. Instead, use the ISO C and C++
conformant name: _fdopen. See online help for details. [D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj]
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
> > 
> > 
> >        "D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default target)
(1) ->
> >        "D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj" (default target) (8) ->
> >        (CustomBuild target) -> 
> >          CUSTOMBUILD : error : downloading 'https://github.com/mesos/3rdparty/raw/master/curl-7.60.0.tar.gz'
failed [D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj]
> >          CUSTOMBUILD : The requested URL returned error : 404 Not Found [D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj]
> >          CUSTOMBUILD : error : downloading 'https://github.com/mesos/3rdparty/raw/master/curl-7.60.0.tar.gz'
failed [D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj]
> >          CUSTOMBUILD : The requested URL returned error : 404 Not Found [D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj]
> >          CUSTOMBUILD : error : downloading 'https://github.com/mesos/3rdparty/raw/master/curl-7.60.0.tar.gz'
failed [D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj]
> >          CUSTOMBUILD : The requested URL returned error : 404 Not Found [D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj]
> >          CUSTOMBUILD : error : downloading 'https://github.com/mesos/3rdparty/raw/master/curl-7.60.0.tar.gz'
failed [D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj]
> >          CUSTOMBUILD : The requested URL returned error : 404 Not Found [D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj]
> >          CUSTOMBUILD : error : downloading 'https://github.com/mesos/3rdparty/raw/master/curl-7.60.0.tar.gz'
failed [D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj]
> >          CUSTOMBUILD : The requested URL returned error : 404 Not Found [D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj]
> >          CUSTOMBUILD : error : downloading 'https://github.com/mesos/3rdparty/raw/master/curl-7.60.0.tar.gz'
failed [D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj]
> >          CUSTOMBUILD : The requested URL returned error : 404 Not Found [D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj]
> > 
> >     141 Warning(s)
> >     12 Error(s)
> > 
> > Time Elapsed 00:09:12.21
> > ```
> > 
> > - [libprocess-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1935/mesos-review-67932/logs/libprocess-tests-cmake-stdout.log):
> > 
> > ```
> >          d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(1520):
warning C4244: '+=': conversion from '__int64' to 'uint32_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
> >          d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(1689):
warning C4244: '+=': conversion from '__int64' to 'uint32_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
> >          d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2273):
warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
> >          d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2280):
warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
> >          d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2292):
warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
> >          d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2301):
warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
> >          d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2401):
warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
> > 
> > 
> >        "D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" (default
target) (1) ->
> >        "D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj" (default target) (8) ->
> >        (CustomBuild target) -> 
> >          CUSTOMBUILD : error : downloading 'https://github.com/mesos/3rdparty/raw/master/curl-7.60.0.tar.gz'
failed [D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj]
> >          CUSTOMBUILD : The requested URL returned error : 404 Not Found [D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj]
> >          CUSTOMBUILD : error : downloading 'https://github.com/mesos/3rdparty/raw/master/curl-7.60.0.tar.gz'
failed [D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj]
> >          CUSTOMBUILD : The requested URL returned error : 404 Not Found [D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj]
> >          CUSTOMBUILD : error : downloading 'https://github.com/mesos/3rdparty/raw/master/curl-7.60.0.tar.gz'
failed [D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj]
> >          CUSTOMBUILD : The requested URL returned error : 404 Not Found [D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj]
> >          CUSTOMBUILD : error : downloading 'https://github.com/mesos/3rdparty/raw/master/curl-7.60.0.tar.gz'
failed [D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj]
> >          CUSTOMBUILD : The requested URL returned error : 404 Not Found [D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj]
> >          CUSTOMBUILD : error : downloading 'https://github.com/mesos/3rdparty/raw/master/curl-7.60.0.tar.gz'
failed [D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj]
> >          CUSTOMBUILD : The requested URL returned error : 404 Not Found [D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj]
> >          CUSTOMBUILD : error : downloading 'https://github.com/mesos/3rdparty/raw/master/curl-7.60.0.tar.gz'
failed [D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj]
> >          CUSTOMBUILD : The requested URL returned error : 404 Not Found [D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj]
> > 
> >     18 Warning(s)
> >     12 Error(s)
> > 
> > Time Elapsed 00:01:28.71
> > ```
> > 
> > - [mesos-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1935/mesos-review-67932/logs/mesos-tests-cmake-stdout.log):
> > 
> > ```
> >          d:\dcos\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(278):
warning C4996: 'stricmp': The POSIX name for this item is deprecated. Instead, use the ISO
C and C++ conformant name: _stricmp. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
> >          d:\dcos\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(289):
warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s
instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details.
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
> >          d:\dcos\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(290):
warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s
instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details.
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
> >          d:\dcos\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(293):
warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s
instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details.
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
> >          d:\dcos\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\plugins\cram.c(138):
warning C4477: 'snprintf' : format string '%lu' requires an argument of type 'unsigned long',
but variadic argument 1 has type 'time_t' [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
> >          d:\dcos\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\plugins\cram.c(157):
warning C4996: 'sprintf': This function or variable may be unsafe. Consider using sprintf_s
instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details.
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
> >          d:\dcos\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\plugins\cram.c(293):
warning C4996: 'strncpy': This function or variable may be unsafe. Consider using strncpy_s
instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details.
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
> > 
> > 
> >        "D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
> >        "D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj" (default target) (7) ->
> >        (CustomBuild target) -> 
> >          CUSTOMBUILD : error : downloading 'https://github.com/mesos/3rdparty/raw/master/curl-7.60.0.tar.gz'
failed [D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj]
> >          CUSTOMBUILD : The requested URL returned error : 404 Not Found [D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj]
> >          CUSTOMBUILD : error : downloading 'https://github.com/mesos/3rdparty/raw/master/curl-7.60.0.tar.gz'
failed [D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj]
> >          CUSTOMBUILD : The requested URL returned error : 404 Not Found [D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj]
> >          CUSTOMBUILD : error : downloading 'https://github.com/mesos/3rdparty/raw/master/curl-7.60.0.tar.gz'
failed [D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj]
> >          CUSTOMBUILD : The requested URL returned error : 404 Not Found [D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj]
> >          CUSTOMBUILD : error : downloading 'https://github.com/mesos/3rdparty/raw/master/curl-7.60.0.tar.gz'
failed [D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj]
> >          CUSTOMBUILD : The requested URL returned error : 404 Not Found [D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj]
> >          CUSTOMBUILD : error : downloading 'https://github.com/mesos/3rdparty/raw/master/curl-7.60.0.tar.gz'
failed [D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj]
> >          CUSTOMBUILD : The requested URL returned error : 404 Not Found [D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj]
> >          CUSTOMBUILD : error : downloading 'https://github.com/mesos/3rdparty/raw/master/curl-7.60.0.tar.gz'
failed [D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj]
> >          CUSTOMBUILD : The requested URL returned error : 404 Not Found [D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj]
> > 
> >     172 Warning(s)
> >     12 Error(s)
> > 
> > Time Elapsed 00:05:08.45
> > ```
> 
> Andrew Schwartzmeyer wrote:
>     We will need to get this taken care of; which first requires pushing the new cURL
tarball to https://github.com/mesos/3rdparty/

This is in, so give this review an update and we'll see if the CI passes.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67932/#review206119
-----------------------------------------------------------


On July 18, 2018, 2:27 a.m., Liangyu Zhao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67932/
> -----------------------------------------------------------
> 
> (Updated July 18, 2018, 2:27 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `tar` command cannot work successfully on Windows, so use `wclayer`
> instead. Note that the folder generated from extraction also cannot be
> deleted by `rmdir`, so the GC is also changed to use `wclayer remove`.
> 
> 
> Diffs
> -----
> 
>   src/common/command_utils.hpp 525f9c1c37b74f7e4cc71fdc8d52944226998ddc 
>   src/common/command_utils.cpp 7dfcc9ff74bcf044d47b803ebc42cf63fba89d17 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp a5683e3fe15dd35596122fcc0c580ae9d3adf7f2

>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 85aad25ac8ecfda125be85fb46d882c3982f3930

> 
> 
> Diff: https://reviews.apache.org/r/67932/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Liangyu Zhao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message