mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.
Date Tue, 31 Jul 2018 00:30:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67932/#review206625
-----------------------------------------------------------




src/common/command_utils.cpp
Lines 186 (patched)
<https://reviews.apache.org/r/67932/#comment289668>

    ?



src/common/command_utils.cpp
Lines 188-191 (patched)
<https://reviews.apache.org/r/67932/#comment289669>

    Trying to think of a cleaner way to do this...



src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp
Line 381 (original), 388 (patched)
<https://reviews.apache.org/r/67932/#comment289670>

    Did we change behavior here? This is in a loop, so the original code was constantly adding
to the front, whereas now we're adding the back (IMHO original code smells a bit funny).



src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp
Line 416 (original), 433-455 (patched)
<https://reviews.apache.org/r/67932/#comment289672>

    Goodness, but it looks like the best we can do here.



src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp
Line 430 (original), 469 (patched)
<https://reviews.apache.org/r/67932/#comment289675>

    Why do we have to do this now?



src/slave/containerizer/mesos/provisioner/docker/store.cpp
Lines 379-380 (patched)
<https://reviews.apache.org/r/67932/#comment289678>

    I take it that the `wclayer` command in `wclayer_remove` is supposed to remove the directory?



src/slave/containerizer/mesos/provisioner/docker/store.cpp
Lines 490 (patched)
<https://reviews.apache.org/r/67932/#comment289679>

    Last I remember, `flags.docker_store_dir` was some Linux path; did we get that fixed (or
am I misremembering)?


- Andrew Schwartzmeyer


On July 18, 2018, 2:27 a.m., Liangyu Zhao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67932/
> -----------------------------------------------------------
> 
> (Updated July 18, 2018, 2:27 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `tar` command cannot work successfully on Windows, so use `wclayer`
> instead. Note that the folder generated from extraction also cannot be
> deleted by `rmdir`, so the GC is also changed to use `wclayer remove`.
> 
> 
> Diffs
> -----
> 
>   src/common/command_utils.hpp 525f9c1c37b74f7e4cc71fdc8d52944226998ddc 
>   src/common/command_utils.cpp 7dfcc9ff74bcf044d47b803ebc42cf63fba89d17 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp a5683e3fe15dd35596122fcc0c580ae9d3adf7f2

>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 85aad25ac8ecfda125be85fb46d882c3982f3930

> 
> 
> Diff: https://reviews.apache.org/r/67932/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Liangyu Zhao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message