mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Liangyu Zhao via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.
Date Tue, 31 Jul 2018 18:11:28 GMT


> On July 31, 2018, 12:30 a.m., Andrew Schwartzmeyer wrote:
> > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp
> > Line 381 (original), 388 (patched)
> > <https://reviews.apache.org/r/67932/diff/3/?file=2061482#file2061482line388>
> >
> >     Did we change behavior here? This is in a loop, so the original code was constantly
adding to the front, whereas now we're adding the back (IMHO original code smells a bit funny).

Nope, in line 469, I reverse the vector. It's just not cool to continuously add stuff at front
in vector.


> On July 31, 2018, 12:30 a.m., Andrew Schwartzmeyer wrote:
> > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp
> > Line 430 (original), 469 (patched)
> > <https://reviews.apache.org/r/67932/diff/3/?file=2061482#file2061482line469>
> >
> >     Why do we have to do this now?

Explained above.


> On July 31, 2018, 12:30 a.m., Andrew Schwartzmeyer wrote:
> > src/slave/containerizer/mesos/provisioner/docker/store.cpp
> > Lines 379-380 (patched)
> > <https://reviews.apache.org/r/67932/diff/3/?file=2061483#file2061483line379>
> >
> >     I take it that the `wclayer` command in `wclayer_remove` is supposed to remove
the directory?

Yeah, there is some privilege issues that `rmdir` does not work here. To remove the directory,
we have to use `wclayer`.


> On July 31, 2018, 12:30 a.m., Andrew Schwartzmeyer wrote:
> > src/slave/containerizer/mesos/provisioner/docker/store.cpp
> > Lines 490 (patched)
> > <https://reviews.apache.org/r/67932/diff/3/?file=2061483#file2061483line490>
> >
> >     Last I remember, `flags.docker_store_dir` was some Linux path; did we get that
fixed (or am I misremembering)?

I believe it has already been fixed. I have run the agent and log this. It turns out to be
a Windows path.


- Liangyu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67932/#review206625
-----------------------------------------------------------


On July 18, 2018, 9:27 a.m., Liangyu Zhao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67932/
> -----------------------------------------------------------
> 
> (Updated July 18, 2018, 9:27 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `tar` command cannot work successfully on Windows, so use `wclayer`
> instead. Note that the folder generated from extraction also cannot be
> deleted by `rmdir`, so the GC is also changed to use `wclayer remove`.
> 
> 
> Diffs
> -----
> 
>   src/common/command_utils.hpp 525f9c1c37b74f7e4cc71fdc8d52944226998ddc 
>   src/common/command_utils.cpp 7dfcc9ff74bcf044d47b803ebc42cf63fba89d17 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp a5683e3fe15dd35596122fcc0c580ae9d3adf7f2

>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 85aad25ac8ecfda125be85fb46d882c3982f3930

> 
> 
> Diff: https://reviews.apache.org/r/67932/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Liangyu Zhao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message