mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 68114: Fixed a gRPC compilation issue for Clang.
Date Tue, 31 Jul 2018 20:56:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68114/#review206681
-----------------------------------------------------------



Patch looks great!

Reviews applied: [68091, 68074, 68092, 68114]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On July 31, 2018, 12:05 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68114/
> -----------------------------------------------------------
> 
> (Updated July 31, 2018, 12:05 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-8395
>     https://issues.apache.org/jira/browse/MESOS-8395
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When compiling gRPC with Clang, there are some array-out-of-bound
> warnings due to the use of GLIBC's `__strcmp_cg` macro in the c-ares
> library. With `-Werror` on, these warnings would stop gRPC from
> compiling. This patch ignores such errors.
> 
> 
> Diffs
> -----
> 
>   3rdparty/Makefile.am 26e5d55561731ff03639df31562bb835d9687339 
> 
> 
> Diff: https://reviews.apache.org/r/68114/diff/1/
> 
> 
> Testing
> -------
> 
> `sudo make check` with clang on ubuntu 16.04, which triggers the warnings.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message