mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 68582: Windows: Add `WclayerBackend` to provision Docker image.
Date Sat, 01 Sep 2018 03:25:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68582/#review208214
-----------------------------------------------------------



Patch looks great!

Reviews applied: [68581, 68582]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Aug. 30, 2018, 10:32 p.m., Liangyu Zhao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68582/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2018, 10:32 p.m.)
> 
> 
> Review request for mesos, Akash Gupta and Andrew Schwartzmeyer.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented `WclayerBackend` using `wclayer` from `microsoft/hcsshim`
> to provision Docker image on Windows.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 732368293049b7d9d6f62057344d433637ad44e8 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 157967f75011bdaeededd218ed6c734bd00c1d1d

>   src/slave/containerizer/mesos/provisioner/backends/wclayer.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/backends/wclayer.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/constants.hpp ab488eb3343cf2ad5747e374995e76d26d4eb879

>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp a5683e3fe15dd35596122fcc0c580ae9d3adf7f2

>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 60507aa1b7951666ed758d1b3800eddd67ba7be6

>   src/slave/containerizer/mesos/provisioner/provisioner.cpp ac402fbead81e4b356cb35cea08a00049002e870

> 
> 
> Diff: https://reviews.apache.org/r/68582/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Liangyu Zhao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message