mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Review Request 68594: Made overlay backend destroy more robust.
Date Sat, 01 Sep 2018 04:26:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68594/
-----------------------------------------------------------

Review request for mesos, Chun-Hung Hsiao and Gilbert Song.


Bugs: MESOS-9196
    https://issues.apache.org/jira/browse/MESOS-9196


Repository: mesos


Description
-------

Use MNT_DETACH for `unmount` so that if there are still processes
holding files or directies in the rootfs (e.g., regular filesystem
indexing), the unmount will still be successful. The kernel will cleanup
the mount when the number of references reach zero. Also, do not return
hard failure if `rmdir` failed. It's also possible that `rmdir` returns
EBUSY. See more details in MESOS-9196.


Diffs
-----

  src/slave/containerizer/mesos/provisioner/backends/overlay.cpp e32b9918ac15122477e05ebe701c9425bbefa809



Diff: https://reviews.apache.org/r/68594/diff/1/


Testing
-------

sudo make check


Thanks,

Jie Yu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message