mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 68599: Added an unit test for rootfs cleanup EBUSY fix.
Date Sat, 01 Sep 2018 18:15:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68599/
-----------------------------------------------------------

(Updated Sept. 1, 2018, 11:15 a.m.)


Review request for mesos, Chun-Hung Hsiao and Jie Yu.


Bugs: MESOS-9196
    https://issues.apache.org/jira/browse/MESOS-9196


Repository: mesos


Description
-------

Added an unit test for rootfs cleanup EBUSY fix.


Diffs (updated)
-----

  src/tests/containerizer/provisioner_docker_tests.cpp bf56d603fcc1d99f73beca1871be45787fa1640d



Diff: https://reviews.apache.org/r/68599/diff/2/

Changes: https://reviews.apache.org/r/68599/diff/1-2/


Testing
-------

make check

Verified that the test failed on aufs and overlayfs without the EBUSY fix:
```
[ RUN      ] BackendFlag/ProvisionerDockerBackendTest.ROOT_INTERNET_CURL_DTYPE_RootfsCleanup/0
sh: 1: hadoop: not found
Marked '/' as rslave
Prepared mount '{"flags":20480,"source":"/tmp/BackendFlag_ProvisionerDockerBackendTest_ROOT_INTERNET_CURL_DTYPE_RootfsCleanup_0_LFYXIA/slaves/e27d1fe4-708d-4d13-9df2-92f89eb50597-S0/frameworks/e27d1fe4-708d-4d13-9df2-92f89eb50597-0000/executors/8438ddd3-101b-448a-8a01-09f65e39d82f/runs/b51eead9-eb1a-4764-9200-7ddb9944daa2","target":"/tmp/BackendFlag_ProvisionerDockerBackendTest_ROOT_INTERNET_CURL_DTYPE_RootfsCleanup_0_LFYXIA/provisioner/containers/b51eead9-eb1a-4764-9200-7ddb9944daa2/backends/copy/rootfses/d89a35dd-5ac1-4a01-8ee8-fd757fa2cc1b/mnt/mesos/sandbox"}'
I0901 09:13:02.950115  2165 exec.cpp:162] Version: 1.8.0
I0901 09:13:02.998127  2190 exec.cpp:236] Executor registered on agent e27d1fe4-708d-4d13-9df2-92f89eb50597-S0
I0901 09:13:03.003624  2189 executor.cpp:182] Received SUBSCRIBED event
I0901 09:13:03.005172  2189 executor.cpp:186] Subscribed executor on vagrant-ubuntu-wily-64
I0901 09:13:03.005786  2189 executor.cpp:182] Received LAUNCH event
I0901 09:13:03.008103  2189 executor.cpp:679] Starting task 8438ddd3-101b-448a-8a01-09f65e39d82f
I0901 09:13:03.010752  2189 executor.cpp:499] Running '/vagrant/mesos/build/src/mesos-containerizer
launch <POSSIBLY-SENSITIVE-DATA>'
I0901 09:13:03.046313  2189 executor.cpp:693] Forked command at 2192
[       OK ] BackendFlag/ProvisionerDockerBackendTest.ROOT_INTERNET_CURL_DTYPE_RootfsCleanup/0
(14789 ms)
[ RUN      ] BackendFlag/ProvisionerDockerBackendTest.ROOT_INTERNET_CURL_DTYPE_RootfsCleanup/1
sh: 1: hadoop: not found
Marked '/' as rslave
Prepared mount '{"flags":20480,"source":"/tmp/BackendFlag_ProvisionerDockerBackendTest_ROOT_INTERNET_CURL_DTYPE_RootfsCleanup_1_M7142L/slaves/514ddbb6-76d5-4014-b568-86be14c7c72e-S0/frameworks/514ddbb6-76d5-4014-b568-86be14c7c72e-0000/executors/eaea3cb2-e0fc-4460-8a53-805ec5e6c609/runs/f714ee27-d960-455a-9821-c6dd8ebaeea8","target":"/tmp/BackendFlag_ProvisionerDockerBackendTest_ROOT_INTERNET_CURL_DTYPE_RootfsCleanup_1_M7142L/provisioner/containers/f714ee27-d960-455a-9821-c6dd8ebaeea8/backends/aufs/rootfses/7731d007-43f7-4bd4-8557-e76d5fac0bfa/mnt/mesos/sandbox"}'
I0901 09:13:10.636891  2286 exec.cpp:162] Version: 1.8.0
I0901 09:13:10.661113  2289 exec.cpp:236] Executor registered on agent 514ddbb6-76d5-4014-b568-86be14c7c72e-S0
I0901 09:13:10.666904  2287 executor.cpp:182] Received SUBSCRIBED event
I0901 09:13:10.667912  2287 executor.cpp:186] Subscribed executor on vagrant-ubuntu-wily-64
I0901 09:13:10.668098  2287 executor.cpp:182] Received LAUNCH event
I0901 09:13:10.670292  2287 executor.cpp:679] Starting task eaea3cb2-e0fc-4460-8a53-805ec5e6c609
I0901 09:13:10.673161  2287 executor.cpp:499] Running '/vagrant/mesos/build/src/mesos-containerizer
launch <POSSIBLY-SENSITIVE-DATA>'
I0901 09:13:10.681861  2287 executor.cpp:693] Forked command at 2291
../../src/tests/containerizer/provisioner_docker_tests.cpp:1143: Failure
(wait).failure(): Failed to destroy the provisioned rootfs when destroying container: Collect
failed: Failed to destroy aufs-mounted rootfs '/tmp/BackendFlag_ProvisionerDockerBackendTest_ROOT_INTERNET_CURL_DTYPE_RootfsCleanup_1_M7142L/provisioner/containers/f714ee27-d960-455a-9821-c6dd8ebaeea8/backends/aufs/rootfses/7731d007-43f7-4bd4-8557-e76d5fac0bfa':
Failed to unmount '/tmp/BackendFlag_ProvisionerDockerBackendTest_ROOT_INTERNET_CURL_DTYPE_RootfsCleanup_1_M7142L/provisioner/containers/f714ee27-d960-455a-9821-c6dd8ebaeea8/backends/aufs/rootfses/7731d007-43f7-4bd4-8557-e76d5fac0bfa':
Device or resource busy
[  FAILED  ] BackendFlag/ProvisionerDockerBackendTest.ROOT_INTERNET_CURL_DTYPE_RootfsCleanup/1,
where GetParam() = "aufs" (7387 ms)
[ RUN      ] BackendFlag/ProvisionerDockerBackendTest.ROOT_INTERNET_CURL_DTYPE_RootfsCleanup/2
sh: 1: hadoop: not found
Marked '/' as rslave
Prepared mount '{"flags":20480,"source":"/tmp/BackendFlag_ProvisionerDockerBackendTest_ROOT_INTERNET_CURL_DTYPE_RootfsCleanup_2_jPSRS6/slaves/b11e52f9-e59c-4987-a146-4e2d4f9b553d-S0/frameworks/b11e52f9-e59c-4987-a146-4e2d4f9b553d-0000/executors/822709df-fea4-44af-ab79-293147bf98b6/runs/e68ff58c-e05b-4405-8290-6364ecb3ad19","target":"/tmp/BackendFlag_ProvisionerDockerBackendTest_ROOT_INTERNET_CURL_DTYPE_RootfsCleanup_2_jPSRS6/provisioner/containers/e68ff58c-e05b-4405-8290-6364ecb3ad19/backends/overlay/rootfses/12ed9913-68ec-418c-85b2-003fba6c6bff/mnt/mesos/sandbox"}'
I0901 09:13:18.213227  2364 exec.cpp:162] Version: 1.8.0
I0901 09:13:18.237236  2380 exec.cpp:236] Executor registered on agent b11e52f9-e59c-4987-a146-4e2d4f9b553d-S0
I0901 09:13:18.243091  2380 executor.cpp:182] Received SUBSCRIBED event
I0901 09:13:18.243966  2380 executor.cpp:186] Subscribed executor on vagrant-ubuntu-wily-64
I0901 09:13:18.244210  2380 executor.cpp:182] Received LAUNCH event
I0901 09:13:18.244988  2380 executor.cpp:679] Starting task 822709df-fea4-44af-ab79-293147bf98b6
I0901 09:13:18.247653  2380 executor.cpp:499] Running '/vagrant/mesos/build/src/mesos-containerizer
launch <POSSIBLY-SENSITIVE-DATA>'
I0901 09:13:18.258003  2380 executor.cpp:693] Forked command at 2388
../../src/tests/containerizer/provisioner_docker_tests.cpp:1143: Failure
(wait).failure(): Failed to destroy the provisioned rootfs when destroying container: Collect
failed: Failed to destroy overlay-mounted rootfs '/tmp/BackendFlag_ProvisionerDockerBackendTest_ROOT_INTERNET_CURL_DTYPE_RootfsCleanup_2_jPSRS6/provisioner/containers/e68ff58c-e05b-4405-8290-6364ecb3ad19/backends/overlay/rootfses/12ed9913-68ec-418c-85b2-003fba6c6bff':
Failed to unmount '/tmp/BackendFlag_ProvisionerDockerBackendTest_ROOT_INTERNET_CURL_DTYPE_RootfsCleanup_2_jPSRS6/provisioner/containers/e68ff58c-e05b-4405-8290-6364ecb3ad19/backends/overlay/rootfses/12ed9913-68ec-418c-85b2-003fba6c6bff':
Device or resource busy
[  FAILED  ] BackendFlag/ProvisionerDockerBackendTest.ROOT_INTERNET_CURL_DTYPE_RootfsCleanup/2,
where GetParam() = "overlay" (7324 ms)
[----------] 3 tests from BackendFlag/ProvisionerDockerBackendTest (29894 ms total)

[----------] Global test environment tear-down
[==========] 3 tests from 1 test case ran. (29925 ms total)
[  PASSED  ] 1 test.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] BackendFlag/ProvisionerDockerBackendTest.ROOT_INTERNET_CURL_DTYPE_RootfsCleanup/1,
where GetParam() = "aufs"
[  FAILED  ] BackendFlag/ProvisionerDockerBackendTest.ROOT_INTERNET_CURL_DTYPE_RootfsCleanup/2,
where GetParam() = "overlay"
```


Thanks,

Gilbert Song


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message