mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 68600: Added a unit test for plugin crash during an agent failover.
Date Sun, 02 Sep 2018 02:31:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68600/#review208233
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Sept. 1, 2018, 5:31 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68600/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2018, 5:31 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8429
>     https://issues.apache.org/jira/browse/MESOS-8429
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If a CSI plugin is crashed during agent failover, the residual socket
> file would exist during SLRP recovery. This test verifies that the
> plugin is properly cleaned up during recovery so the plugin can be
> restarted.
> 
> 
> Diffs
> -----
> 
>   src/examples/test_csi_plugin.cpp 93301f8af9b494bbcecb10e6cd4f4073b6a05070 
>   src/tests/storage_local_resource_provider_tests.cpp 9d0020cb22d8f674c6271712a93db7f446824d55

> 
> 
> Diff: https://reviews.apache.org/r/68600/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> NOTE: This test will fail without the following patch.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message