mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 68612: Consolidated Java header targets using makefile patterns.
Date Mon, 03 Sep 2018 20:12:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68612/#review208275
-----------------------------------------------------------


Fix it, then Ship it!




Awesome!


src/Makefile.am
Line 2003 (original), 2003 (patched)
<https://reviews.apache.org/r/68612/#comment292002>

    Please add a short comment explaining what this does - e.g. showing 1-2 examples from
the original.


- Till Toenshoff


On Sept. 3, 2018, 5:47 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68612/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2018, 5:47 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-8921
>     https://issues.apache.org/jira/browse/MESOS-8921
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Consolidated Java header targets using makefile patterns.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am cf0cf22b3f582d3d4427f13288af3845aef45263 
> 
> 
> Diff: https://reviews.apache.org/r/68612/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message