mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 68601: Cleaned up residual CSI endpoint sockets for terminated plugins.
Date Mon, 03 Sep 2018 22:31:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68601/
-----------------------------------------------------------

(Updated Sept. 3, 2018, 10:31 p.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
-------

Addressed Benjamin's comments.


Bugs: MESOS-8429
    https://issues.apache.org/jira/browse/MESOS-8429


Repository: mesos


Description
-------

If a CSI plugin is crashed during agent failover, the residual socket
file would exist during SLRP recovery, which may in turn make the plugin
fail to restart. This patch cleans up the residual socket files to avoid
such failures.


Diffs (updated)
-----

  src/resource_provider/storage/provider.cpp ab1467c22ded269cb42fc52d3f00fb936fc42c7f 


Diff: https://reviews.apache.org/r/68601/diff/3/

Changes: https://reviews.apache.org/r/68601/diff/2-3/


Testing
-------

sudo make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message