mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 68489: Generated a new bundle of Boost headers.
Date Tue, 04 Sep 2018 23:43:14 GMT


> On Sept. 4, 2018, 3:37 a.m., Benjamin Mahler wrote:
> > Thanks for the nice readme!
> > 
> > I can't pull this down:
> > 
> > ```
> > ./support/apply-reviews.py -r 68489
> > Congratulations! You have Python 3 installed correctly.
> > Please start using the scripts in `support/python3`.
> > Please also set the environment variable `MESOS_SUPPORT_PYTHON` to `3`
> > so that the Git hooks use the Python 3 scripts.
> > 2018-09-03 20:30:40 URL:https://reviews.apache.org/r/68489/diff/raw/ [2534/2534]
-> "68489.patch" [1]
> > error: missing binary patch data for '3rdparty/boost-1.65.0.tar.gz'
> > error: binary patch does not apply to '3rdparty/boost-1.65.0.tar.gz'
> > error: 3rdparty/boost-1.65.0.tar.gz: patch does not apply
> > ```
> > 
> > You could post as a PR, send me a patch file, or branch.
> 
> Benjamin Mahler wrote:
>     How about the following commit summary? `Upgraded bundled boost to 1.65.0.`

Oh, I see we're not upgrading, how about clarifying in the commit summary / description what
you're including in the boost bundle?


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68489/#review208284
-----------------------------------------------------------


On Aug. 23, 2018, 10:15 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68489/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2018, 10:15 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Also added `boost.md` regarding the Boost bundle,
> including the upgrading guide.
> 
> 
> Diffs
> -----
> 
>   3rdparty/boost-1.65.0.tar.gz 25973f3ec5d3ecb09d82774780726ee7dfd50518 
>   3rdparty/boost.md PRE-CREATION 
>   3rdparty/cmake/Versions.cmake c65d7b3d2d48ce9d0b4777aeb12fdf5b605803ac 
> 
> 
> Diff: https://reviews.apache.org/r/68489/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message