mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 68636: Reserved vector capacities within Master::offer.
Date Thu, 06 Sep 2018 01:20:57 GMT


> On Sept. 6, 2018, 12:41 a.m., Meng Zhu wrote:
> > src/master/master.cpp
> > Lines 9249 (patched)
> > <https://reviews.apache.org/r/68636/diff/1/?file=2082765#file2082765line9249>
> >
> >     can you put the type here instead of `auto`?

Unfortunately templated types don't work inside `foreach(|key|value)`, I would need a typedef.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68636/#review208387
-----------------------------------------------------------


On Sept. 5, 2018, 10:15 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68636/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2018, 10:15 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp e307df001fba3afbd128c3c0d9db955d6777186a 
> 
> 
> Diff: https://reviews.apache.org/r/68636/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message